Abstract: The implementation of data collection in making and packing workshop is complicated due to numbers of controllers, sophisticated communication interfaces in a variety of making and packing equipment of different models.The general frame of data collecting system for making and packing equipment was introduced by taking Shanghai Cigarette Factory as an example, including:field layer, workshop monitoring layer, factory monitoring lay er and Intranet.The data shunting and real time data communication were discussed emphatically.Taking account of the equipment's characteristics in making and packing workshop, some personal viewpoints and suggestions about data collecting system were proposed.